[webkit-reviews] review denied: [Bug 200249] Fix non-thread safe use of WeakPtr under sendSecItemRequest() : [Attachment 375159] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 10:25:41 PDT 2019


Alex Christensen <achristensen at apple.com> has denied  review:
Bug 200249: Fix non-thread safe use of WeakPtr under sendSecItemRequest()
https://bugs.webkit.org/show_bug.cgi?id=200249

Attachment 375159: Patch

https://bugs.webkit.org/attachment.cgi?id=375159&action=review




--- Comment #15 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375159
  --> https://bugs.webkit.org/attachment.cgi?id=375159
Patch

If we're on the main thread we should send a synchronous message.  If we're not
on the main thread, we should use sendWithAsyncReply to not block the main
thread.


More information about the webkit-reviews mailing list