[webkit-reviews] review granted: [Bug 199848] [WebKit] Add PageLoadState::Observer C API : [Attachment 375147] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 199848: [WebKit] Add PageLoadState::Observer C API
https://bugs.webkit.org/show_bug.cgi?id=199848

Attachment 375147: Patch

https://bugs.webkit.org/attachment.cgi?id=375147&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 375147
  --> https://bugs.webkit.org/attachment.cgi?id=375147
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375147&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:639
> +void
WebPageProxy::setPageLoadStateObserver(UniqueRef<PageLoadState::Observer>&&
observer)

My earlier feedback was mistaken.  We ought to be able to call
WKPageSetPageStateClient with nullptr and have it clear the observer.  That
would bring this back to a std::unique_ptr.  Please do that, add that to the
test, and r=me.