[webkit-reviews] review granted: [Bug 199305] Web Inspector: support `console.screenshot` with subclasses of CanvasRenderingContext : [Attachment 373086] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 199305: Web Inspector: support `console.screenshot` with subclasses of
CanvasRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=199305

Attachment 373086: Patch

https://bugs.webkit.org/attachment.cgi?id=373086&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 373086
  --> https://bugs.webkit.org/attachment.cgi?id=373086
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373086&action=review

r=me

> Source/WebCore/page/PageConsoleClient.cpp:327
> +    if (dataURL.isEmpty() || dataURL == "data:,") {

This seems out of place in this patch, or does this happen sometimes with empty
contexts?