[webkit-reviews] review granted: [Bug 199307] Web Inspector: support `console.screenshot` with dataURL strings : [Attachment 373087] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 199307: Web Inspector: support `console.screenshot` with dataURL strings
https://bugs.webkit.org/show_bug.cgi?id=199307

Attachment 373087: Patch

https://bugs.webkit.org/attachment.cgi?id=373087&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 373087
  --> https://bugs.webkit.org/attachment.cgi?id=373087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373087&action=review

r=me

> Source/WebCore/page/PageConsoleClient.cpp:315
> +    if (dataURL.isEmpty() || dataURL == "data:,") {

Seems like a weird case check for just "data:,". Someone could do:
`data:image/png," and bypass this.