[webkit-reviews] review granted: [Bug 199308] Web Inspector: print the target of `console.screenshot` last so the target is the closest item to the image : [Attachment 373083] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 199308: Web Inspector: print the target of `console.screenshot` last so the
target is the closest item to the image
https://bugs.webkit.org/show_bug.cgi?id=199308

Attachment 373083: Patch

https://bugs.webkit.org/attachment.cgi?id=373083&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 373083
  --> https://bugs.webkit.org/attachment.cgi?id=373083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373083&action=review

r=me, though this has changes to the default log path so ensure this doesn't
break regular logging on some pages.

> Source/WebCore/page/PageConsoleClient.cpp:297
> +	   if (messageText.isEmpty())
> +	       messageText = "Viewport"_s;

We would probably want to make this a message type in the future so that the
frontend can consider localizing this.

> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:325
>	   // FIXME: Better handle WI.ConsoleMessage.MessageSource.Network once
it has request info.

Should we make this an assert not reached?