[webkit-reviews] review granted: [Bug 199773] [WebGPU] Convert GPUComputePipeline LOG statements to generate GPUErrors : [Attachment 374067] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 199773: [WebGPU] Convert GPUComputePipeline LOG statements to generate
GPUErrors
https://bugs.webkit.org/show_bug.cgi?id=199773

Attachment 374067: Patch

https://bugs.webkit.org/attachment.cgi?id=374067&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 374067
  --> https://bugs.webkit.org/attachment.cgi?id=374067
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374067&action=review

> LayoutTests/webgpu/compute-pipeline-errors.html:45
> +    const badMSL = `We should hydrate. With some beers.`;

👎 please no

Also beers usually have enough salt that they don’t hydrate you