[webkit-reviews] review granted: [Bug 199763] [WHLSL] Return statements don't need to keep track of the function they're in : [Attachment 374046] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 199763: [WHLSL] Return statements don't need to keep track of the function
they're in
https://bugs.webkit.org/show_bug.cgi?id=199763

Attachment 374046: Patch

https://bugs.webkit.org/attachment.cgi?id=374046&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 374046
  --> https://bugs.webkit.org/attachment.cgi?id=374046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374046&action=review

> Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLReturn.h:-60
> -    void setFunction(FunctionDefinition* functionDefinition) { m_function =
functionDefinition; }

We might have to add this back in if we add a pass to inline things.