[webkit-reviews] review granted: [Bug 199728] Begin unifying TestWebKitAPI build : [Attachment 373959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 14:10:40 PDT 2019


Keith Miller <keith_miller at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199728: Begin unifying TestWebKitAPI build
https://bugs.webkit.org/show_bug.cgi?id=199728

Attachment 373959: Patch

https://bugs.webkit.org/attachment.cgi?id=373959&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 373959
  --> https://bugs.webkit.org/attachment.cgi?id=373959
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373959&action=review

r=me with comment.

> Tools/TestWebKitAPI/Scripts/generate-unified-sources.sh:21
> +    echo "Using unified source list files: Sources.txt, SourcesCocoa.txt"

Is there a way to make this echo use the same values that are passed to the
generate-unified-source-bundles.rb call below?


More information about the webkit-reviews mailing list