[webkit-reviews] review granted: [Bug 199730] Begin unifying WebKitLegacy sources : [Attachment 374019] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 14:09:16 PDT 2019


Keith Miller <keith_miller at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199730: Begin unifying WebKitLegacy sources
https://bugs.webkit.org/show_bug.cgi?id=199730

Attachment 374019: Patch

https://bugs.webkit.org/attachment.cgi?id=374019&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 374019
  --> https://bugs.webkit.org/attachment.cgi?id=374019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=374019&action=review

r=me with comment.

> Source/WebKitLegacy/scripts/generate-unified-sources.sh:21
> +    echo "Using unified source list files: Sources.txt, SourcesCocoa.txt"

Is there a way to make this echo use the same values that are passed to the
generate-unified-source-bundles.rb call below?


More information about the webkit-reviews mailing list