[webkit-reviews] review granted: [Bug 199584] Validate reply block signature in [WKRemoteObjectRegistry _invokeMethod] : [Attachment 373728] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199584: Validate reply block signature in [WKRemoteObjectRegistry
_invokeMethod]
https://bugs.webkit.org/show_bug.cgi?id=199584

Attachment 373728: Patch

https://bugs.webkit.org/attachment.cgi?id=373728&action=review




--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 373728
  --> https://bugs.webkit.org/attachment.cgi?id=373728
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373728&action=review

r=me

> Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:205
> +    ASSERT(expectedBlockSignature);

Should we null check and return false here too (as above)?

> Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:246
> +	       // Validate the signature.

Not sure this comment adds anything. The function name is very clear.