[webkit-reviews] review granted: [Bug 199618] [Pointer Events] Scroll indicators should not show for scrollable content with touch-action: none : [Attachment 373714] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 199618: [Pointer Events] Scroll indicators should not show for scrollable
content with touch-action: none
https://bugs.webkit.org/show_bug.cgi?id=199618

Attachment 373714: Patch

https://bugs.webkit.org/attachment.cgi?id=373714&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 373714
  --> https://bugs.webkit.org/attachment.cgi?id=373714
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373714&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1402
> +	   if ([view isKindOfClass:[UIScrollView class]]) {
> +	       if (auto* delegate = ((UIScrollView*)view).delegate)
> +		   return [delegate
isKindOfClass:[WKScrollingNodeScrollViewDelegate class]];
> +	   }

You could just check that the UIScrollView is a WKChildScrollView?