[webkit-reviews] review denied: [Bug 193458] Resolve confusion between HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain and HTTPCookieAcceptPolicy::ExclusivelyFromMainDocumentDomain : [Attachment 373558] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 193458: Resolve confusion between
HTTPCookieAcceptPolicy::OnlyFromMainDocumentDomain and
HTTPCookieAcceptPolicy::ExclusivelyFromMainDocumentDomain
https://bugs.webkit.org/show_bug.cgi?id=193458

Attachment 373558: Patch

https://bugs.webkit.org/attachment.cgi?id=373558&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373558
  --> https://bugs.webkit.org/attachment.cgi?id=373558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373558&action=review

Oh, I see EWS is sad.

>> Source/WebCore/platform/network/curl/CookieJarDB.h:-42
>> -
> 
> We agree to the basic concept of this bug, but we still need this definition
for WK1. It's not good idea to refer WK2 definitions from Legacy, isn't it?

You're right. I thought it was a WebCore type, but it's not. That's why the
WinCairo build is failing.