[webkit-reviews] review granted: [Bug 199613] REGRESSION(r244906): Crash in WebCore::positionOffsetValue : [Attachment 373708] patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s request
for review:
Bug 199613: REGRESSION(r244906): Crash in WebCore::positionOffsetValue
https://bugs.webkit.org/show_bug.cgi?id=199613

Attachment 373708: patch

https://bugs.webkit.org/attachment.cgi?id=373708&action=review




--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 373708
  --> https://bugs.webkit.org/attachment.cgi?id=373708
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373708&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:794
> +	       auto& enclosingClippingBox =
> +		   box.enclosingClippingBoxForStickyPosition();

why 2 lines.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:448
> +    auto* clipLayer = layer()->enclosingOverflowClipLayer(ExcludeSelf);

I guess if sticky does not produce a layer, we have bigger problems than this
null deref.