[webkit-reviews] review granted: [Bug 199599] Speculative fix for crashes under LocalStorageDatabaseTracker::databasePath() : [Attachment 373678] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199599: Speculative fix for crashes under
LocalStorageDatabaseTracker::databasePath()
https://bugs.webkit.org/show_bug.cgi?id=199599

Attachment 373678: Patch

https://bugs.webkit.org/attachment.cgi?id=373678&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373678
  --> https://bugs.webkit.org/attachment.cgi?id=373678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373678&action=review

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabaseTracker.h:78
> -    String m_localStorageDirectory;
> +    const String m_localStorageDirectory;

Can we add a comment saying why it's not safe to use this in a background
thread?