[webkit-reviews] review granted: [Bug 199598] UserData::decode should return false when decoding an unrecognized type : [Attachment 373677] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199598: UserData::decode should return false when decoding an unrecognized
type
https://bugs.webkit.org/show_bug.cgi?id=199598

Attachment 373677: Patch

https://bugs.webkit.org/attachment.cgi?id=373677&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373677
  --> https://bugs.webkit.org/attachment.cgi?id=373677
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373677&action=review

> Source/WebKit/Shared/UserData.cpp:601
>	   ASSERT_NOT_REACHED();
> +	   return false;

I'm a bit surprised that we're not already getting a compiler warning / error
about this...