[webkit-reviews] review granted: [Bug 199542] [ContentChangeObserver] Difficult to control videos on iqiyi.com as the actions are mouse hover : [Attachment 373563] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 199542: [ContentChangeObserver] Difficult to control videos on iqiyi.com as
the actions are mouse hover
https://bugs.webkit.org/show_bug.cgi?id=199542

Attachment 373563: Patch

https://bugs.webkit.org/attachment.cgi?id=373563&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 373563
  --> https://bugs.webkit.org/attachment.cgi?id=373563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373563&action=review

> Source/WebCore/ChangeLog:9
> +	   Decouple isVisuallyHidden and isConsideredVisible.Just because an
element is not visually hidden (1px wide content)

. Just

> Source/WebCore/ChangeLog:10
> +	   it is not necessarily qualified to be visible in the context of
hover heuristic.

Who says?