[webkit-reviews] review denied: [Bug 197172] JSC should have public API for unhandled promise rejections : [Attachment 373564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 6 11:15:37 PDT 2019

Keith Miller <keith_miller at apple.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 197172: JSC should have public API for unhandled promise rejections

Attachment 373564: Patch


--- Comment #9 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 373564
  --> https://bugs.webkit.org/attachment.cgi?id=373564

View in context: https://bugs.webkit.org/attachment.cgi?id=373564&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   This patch allows callbacks for unhandled and late-handled promise
rejections to be set via JSC's public C API.
> +	   Since there is no event loop in such an environment, these callbacks
fire off of the microtask queue.
> +	   Callbacks receive the promise and rejection reason as arguments and
their return value is ignored.

To be clear, we do assume there's a run loop in the C API. We just don't have a
way to configure it beyond the default of using the one associated with the
thread the VM was created on. We use that run loop for GC work and for
resolving Wasm compilations. 

I think we should use the same queue for this... but I could be convinced

More information about the webkit-reviews mailing list