[webkit-reviews] review requested: [Bug 198269] Implement MappedFileData for Windows : [Attachment 373420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 15:15:05 PDT 2019

Christopher Reid <chris.reid at sony.com> has asked  for review:
Bug 198269: Implement MappedFileData for Windows

Attachment 373420: Patch


--- Comment #2 from Christopher Reid <chris.reid at sony.com> ---
Created attachment 373420

  --> https://bugs.webkit.org/attachment.cgi?id=373420&action=review


It looks like the only FileSystem Mapping test that was failing was
MappingExistingEmptyFile but it passes after adding the `if (!size) {` check
from the mmap implementation.

I also moved the mmap implementation back to FileSystem.cpp from
FileSystemPOSIX. It would be nice to split it up to posix and glib

The only FileSystem tests failing on windows now are
FileSystemTest.UnicodeDirectoryName and FileSystemTest.GetFileMetadataSymlink.

More information about the webkit-reviews mailing list