[webkit-reviews] review granted: [Bug 199435] AX: CrashTracer: com.apple.WebKit.WebContent at WebKit: WebKit::WebSpeechSynthesisClient::speak : [Attachment 373396] patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 199435: AX: CrashTracer: com.apple.WebKit.WebContent at WebKit:
WebKit::WebSpeechSynthesisClient::speak
https://bugs.webkit.org/show_bug.cgi?id=199435

Attachment 373396: patch

https://bugs.webkit.org/attachment.cgi?id=373396&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 373396
  --> https://bugs.webkit.org/attachment.cgi?id=373396
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373396&action=review

>>>>> Source/WebKit/WebProcess/WebCoreSupport/WebSpeechSynthesisClient.cpp:57
>>>>> + 	   observer->didFinishSpeaking();
>>>> 
>>>> Could speechSynthesisClient() also possibly return nullptr?
>>> 
>>> I looked into it and to my eyes it did not seem so. It looks like it's set
unconditionally
>> 
>> Perhaps it could return a reference, then? I don't think this is required in
this patch, though. It can be done in a follow-up patch.
> 
> let me look into that

m_speechSynthesisClient(WTFMove(pageConfiguration.speechSynthesisClient)) so if
pageConfiguration.speechSynthesisClient is null, it could be null.
I think we should add an extra null check for now. We can turn it to a
reference in the future.