[webkit-reviews] review granted: [Bug 198956] Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side : [Attachment 372412] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 198956: Web Inspector: Debug: "Reset Web Inspector" should also clear the
saved window size and attachment side
https://bugs.webkit.org/show_bug.cgi?id=198956

Attachment 372412: Patch

https://bugs.webkit.org/attachment.cgi?id=372412&action=review




--- Comment #10 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 372412
  --> https://bugs.webkit.org/attachment.cgi?id=372412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372412&action=review

r=me, looks like you addressed Joe's comments.

> Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp:94
> +    CFPreferencesSetAppValue(createKeyForPreferences(key).get(), NULL,
kCFPreferencesCurrentApplication);

You can pass nullptr for the CFPropertyListRef argument. Should fix the [style]
error.