[webkit-reviews] review denied: [Bug 199182] Web Inspector: Elements: allow nodes to be copied and pasted : [Attachment 372819] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 1 20:46:42 PDT 2019

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 199182: Web Inspector: Elements: allow nodes to be copied and pasted

Attachment 372819: Patch


--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 372819
  --> https://bugs.webkit.org/attachment.cgi?id=372819

View in context: https://bugs.webkit.org/attachment.cgi?id=372819&action=review

r-, because of the copy-paste error in WI._paste.

You can add this in a follow up if you want, but I noticed this doesn't work
with comment nodes.

> Source/WebInspectorUI/UserInterface/Base/Main.js:2629
> +    if (selection.isCollapsed && !WI.isEventTargetAnEditableField(event)) {

Decrease indenting with early return:

if (!selection.isCollapsed || WI.isTargetAnEditableField(event))

> Source/WebInspectorUI/UserInterface/Base/Main.js:2631
> +	   if (focusedCopyHandler && typeof focusedCopyHandler.handlePasteEvent
=== "function") {

Was this copied from WI._copy? The comment above looks wrong too.

> Source/WebInspectorUI/UserInterface/Base/Main.js:2649
> +	   return;

Not needed.

More information about the webkit-reviews mailing list