[webkit-reviews] review granted: [Bug 194119] Web Inspector: Make WI.StackedLineChart a WI.View subclass : [Attachment 360796] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 17:51:34 PST 2019


Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194119: Web Inspector: Make WI.StackedLineChart a WI.View subclass
https://bugs.webkit.org/show_bug.cgi?id=194119

Attachment 360796: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=360796&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360796
  --> https://bugs.webkit.org/attachment.cgi?id=360796
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=360796&action=review

rs=me, not sure why this won't apply 🤔, but it looks good to me

> Source/WebInspectorUI/UserInterface/Views/LineChart.js:91
> +	   super.layout();

Oops.  Forgot that :P

> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:43
> +	   this._chart.size = new WI.Size(0, this.height);

I don't think this is necessary, given that you're making the width `0`.  Not
setting a `size` means we don't draw, so it should have the same effect as
setting the width to `0`.


More information about the webkit-reviews mailing list