[webkit-reviews] review granted: [Bug 194130] Constant fold DoubleRep of a numeric constant into a DoubleConstant. : [Attachment 360815] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 31 17:47:32 PST 2019


Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 194130: Constant fold DoubleRep of a numeric constant into a
DoubleConstant.
https://bugs.webkit.org/show_bug.cgi?id=194130

Attachment 360815: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=360815&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 360815
  --> https://bugs.webkit.org/attachment.cgi?id=360815
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=360815&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:793
> +		       m_graph.convertToConstant(node,
JSValue(node->child1()->asNumber()));

do we need purifyNaN here?


More information about the webkit-reviews mailing list