[webkit-reviews] review granted: [Bug 193779] Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction() : [Attachment 360036] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 25 09:06:24 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 193779: Regression(PSON?) Crash under
NavigationState::NavigationClient::decidePolicyForNavigationAction()
https://bugs.webkit.org/show_bug.cgi?id=193779

Attachment 360036: Patch

https://bugs.webkit.org/attachment.cgi?id=360036&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 360036
  --> https://bugs.webkit.org/attachment.cgi?id=360036
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360036&action=review

> Source/WebKit/ChangeLog:13
> +	   We were crashing when trying to get the URL of the main frame, which
was sad because we never
> +	   ended up using the main frame URL. Therefore, this patch drops the
code in question.

The best fix.


More information about the webkit-reviews mailing list