[webkit-reviews] review granted: [Bug 193401] Add API to generate and consume cached bytecode : [Attachment 360114] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 25 08:58:22 PST 2019


Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 193401: Add API to generate and consume cached bytecode
https://bugs.webkit.org/show_bug.cgi?id=193401

Attachment 360114: Patch

https://bugs.webkit.org/attachment.cgi?id=360114&action=review




--- Comment #16 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 360114
  --> https://bugs.webkit.org/attachment.cgi?id=360114
Patch

r=me. I think you can test the unmapping by making a function inside one of the
modules that you call after the JSScript is released. Also, can you add a test
for a constructor too?


More information about the webkit-reviews mailing list