[webkit-reviews] review granted: [Bug 189553] SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds : [Attachment 358965] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 189553: SDK_VARIANT build destinations should be separate from
non-SDK_VARIANT builds
https://bugs.webkit.org/show_bug.cgi?id=189553

Attachment 358965: Patch

https://bugs.webkit.org/attachment.cgi?id=358965&action=review




--- Comment #21 from Tim Horton <thorton at apple.com> ---
Comment on attachment 358965
  --> https://bugs.webkit.org/attachment.cgi?id=358965
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358965&action=review

I don't love the new xcconfigs.

> Tools/ChangeLog:22
> +	   SDK_VARIANT build destinations should be separate from
non-SDK_VARIANT builds

Double changelog

> Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig:1
> +// Copyright (C) 2018 Apple Inc. All rights reserved.

The year has changed