[webkit-reviews] review granted: [Bug 193430] [WHLSL] Add the literal type checker : [Attachment 359245] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 12:30:10 PST 2019


Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 193430: [WHLSL] Add the literal type checker
https://bugs.webkit.org/show_bug.cgi?id=193430

Attachment 359245: Patch

https://bugs.webkit.org/attachment.cgi?id=359245&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 359245
  --> https://bugs.webkit.org/attachment.cgi?id=359245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359245&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:60
> +    LiteralTypeChecker() = default;
> +
> +    virtual ~LiteralTypeChecker() = default;

Not needed.


More information about the webkit-reviews mailing list