[webkit-reviews] review granted: [Bug 192977] [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite : [Attachment 358790] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 192977: [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a
testsuite
https://bugs.webkit.org/show_bug.cgi?id=192977

Attachment 358790: Patch

https://bugs.webkit.org/attachment.cgi?id=358790&action=review




--- Comment #21 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 358790
  --> https://bugs.webkit.org/attachment.cgi?id=358790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358790&action=review

>>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer
.cpp:153
>> +static gboolean
webKitMediaClearKeyDecryptorFindAndSetKey(WebKitMediaClearKeyDecryptPrivate*
priv, RefPtr<WebCore::GstMappedBuffer>&& keyIDBuffer)
> 
> Nit: I don't see a reason to change this from const & to &&, even when
callers don't user this anymore. We are trasferring ownership of what is passed
here and we don't need to.
> 
> Talking about the references, the RefPtr is ok, of course.
> 
> Other than this, the patch LGTM.

I suggested it because the reference was released when passed to this function,
but I don't know why. Of course it's also fine to simply pass a const reference
.