[webkit-reviews] review granted: [Bug 193333] WebDriver: update Create Browsing Context implementation to support newest specification : [Attachment 358837] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Brian Burg
<bburg at apple.com>'s request for review:
Bug 193333: WebDriver: update Create Browsing Context implementation to support
newest specification
https://bugs.webkit.org/show_bug.cgi?id=193333

Attachment 358837: Patch

https://bugs.webkit.org/attachment.cgi?id=358837&action=review




--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 358837
  --> https://bugs.webkit.org/attachment.cgi?id=358837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358837&action=review

This looks good to me. An apple reviewer might want to check the new API,
though.

> Source/WebKit/UIProcess/Automation/Automation.json:335
>		   { "name": "preferNewTab", "type": "boolean", "optional":
true, "description": "Create the new browsing context as a tab in an existing
Automation window, if possible."}

Should we change this now too? Using the enum too and renamed as
presentationHint.