[webkit-reviews] review granted: [Bug 193173] Web Inspector: "white" and "black" aren't recognized as color keywords : [Attachment 358465] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 193173: Web Inspector: "white" and "black" aren't recognized as color
keywords
https://bugs.webkit.org/show_bug.cgi?id=193173

Attachment 358465: Patch

https://bugs.webkit.org/attachment.cgi?id=358465&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358465
  --> https://bugs.webkit.org/attachment.cgi?id=358465
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358465&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:422
>	       // FIXME: <https://webkit.org/b/178636> Web Inspector: Styles:
Make inline widgets work with CSS functions (var(), calc(), etc.)

Does this address this FIXME? Maybe not completely?