[webkit-reviews] review granted: [Bug 192850] [Web Animations] Compute animation effect timing properties in batch : [Attachment 357670] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 192850: [Web Animations] Compute animation effect timing properties in
batch
https://bugs.webkit.org/show_bug.cgi?id=192850

Attachment 357670: Patch

https://bugs.webkit.org/attachment.cgi?id=357670&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 357670
  --> https://bugs.webkit.org/attachment.cgi?id=357670
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357670&action=review

> Source/WebCore/animation/AnimationEffect.cpp:177
> +    BasicEffectTiming basicEffectTiming;
> +    basicEffectTiming.localTime = localTime;
> +    basicEffectTiming.endTime = endTime;
> +    basicEffectTiming.activeDuration = activeDuration;
> +    basicEffectTiming.activeTime = activeTime;
> +    basicEffectTiming.phase = phase;

Maybe make a constructor that takes these as parameters?