[webkit-reviews] review granted: [Bug 192451] Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view : [Attachment 358372] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 192451: Web Inspector: subclasses of WI.ClusterContentView don't
save/restore content views after the initial view
https://bugs.webkit.org/show_bug.cgi?id=192451

Attachment 358372: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=358372&action=review




--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358372
  --> https://bugs.webkit.org/attachment.cgi?id=358372
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=358372&action=review

r=me, nice fix :)

One thing I just noticed (not sure if this is new) is that switching from
"JavaScript Allocations" to "Memory" to "JavaScript & Events" causes the path
components of "JavaScript Allocations" to briefly appear before switching to
those of "JavaScript & Events".  Probably uses a rAF to update?

> Source/WebInspectorUI/UserInterface/Models/BackForwardEntry.js:97
> +	   if (this._contentView.shouldSaveStateOnHide) {

NIT: I'd call this `shouldSaveStateWhenHidden`.  I usually don't like shorter
prepositions in names (e.g. using `Did` instead of the past tense).