[webkit-reviews] review denied: [Bug 193089] Web Inspector: Elements tab should toggle visibility for all selected nodes : [Attachment 358241] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 4 15:33:28 PST 2019


Devin Rousso <drousso at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 193089: Web Inspector: Elements tab should toggle visibility for all
selected nodes
https://bugs.webkit.org/show_bug.cgi?id=193089

Attachment 358241: Patch

https://bugs.webkit.org/attachment.cgi?id=358241&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358241
  --> https://bugs.webkit.org/attachment.cgi?id=358241
Patch

r- for now, as I'm pretty sure we can make a version of this that isn't able to
get out of sync with the actual DOM tree.  If you can prove otherwise, I'll r+
(after the other changes).


More information about the webkit-reviews mailing list