[webkit-reviews] review granted: [Bug 189608] [iOS] ERROR: post-layout: dirty renderer(s) in WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker() : [Attachment 358369] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 189608: [iOS] ERROR: post-layout: dirty renderer(s) in
WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker()
https://bugs.webkit.org/show_bug.cgi?id=189608

Attachment 358369: Patch

https://bugs.webkit.org/attachment.cgi?id=358369&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 358369
  --> https://bugs.webkit.org/attachment.cgi?id=358369
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358369&action=review

> Source/WebCore/rendering/RenderFrameSet.cpp:497
> +static void clearSiblingSubtrees(RenderBox* sibling, RenderFrameSet&
frameSet)

resetFrameRendererAndDescendents

> Source/WebCore/rendering/RenderFrameSet.cpp:549
>      // all the remaining frames are hidden to avoid ugly spurious unflowed
frames

Make this a full sentence.

> Source/WebCore/rendering/RenderFrameSet.cpp:653
>      // all the remaining frames are hidden to avoid ugly spurious unflowed
frames

Make this a full sentence.