[webkit-reviews] review requested: [Bug 192451] Web Inspector: subclasses of WI.ClusterContentView don't save/restore content views after the initial view : [Attachment 358372] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 4 14:28:50 PST 2019
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 192451: Web Inspector: subclasses of WI.ClusterContentView don't
save/restore content views after the initial view
https://bugs.webkit.org/show_bug.cgi?id=192451
Attachment 358372: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=358372&action=review
--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 358372
--> https://bugs.webkit.org/attachment.cgi?id=358372&action=review
[PATCH] Proposed Fix
Tested this with:
- JS Timeline - Call Trees / Events - Toggle between tabs after toggling this
picker
- Heap Timelines - Instances / Object Graph - Toggle between tabs after
toggling this picker
- SVG Image view - Image / Source - Toggle between an SVG and PNG after
toggling this picker
The back/forward list felt a little messed up in Timelines but it already feels
a little confused, so it is no worse. This however is much better default
behavior for switching tabs with Timelines.
More information about the webkit-reviews
mailing list