[webkit-reviews] review granted: [Bug 193016] Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent running WebKit layout tests : [Attachment 358146] Patch v3

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 193016: Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent
running WebKit layout tests
https://bugs.webkit.org/show_bug.cgi?id=193016

Attachment 358146: Patch v3

https://bugs.webkit.org/attachment.cgi?id=358146&action=review




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 358146
  --> https://bugs.webkit.org/attachment.cgi?id=358146
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=358146&action=review

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
199
> +static inline RetainPtr<CMSampleBufferRef>
copySampleBufferWithCurrentTimeStamp(CMSampleBufferRef originalBuffer)

Maybe this shouldn't have 'copy' in the name now that it returns a RetainPtr<>

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
259
> +    m_videoBufferPool.append(bufferWithCurrentTime);

WTFMove()?

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
264
> +    auto& basicDescription = *WTF::get<const
AudioStreamBasicDescription*>(description.platformDescription().description);

Why get basicDescription as a reference and then turn it back into a pointer
two lines later?

>
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
328
> +    m_audioBufferPool.append(sampleBuffer);

WTFMove()?