[webkit-reviews] review granted: [Bug 192321] Support css-color-4 rgb functions : [Attachment 358098] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 2 11:00:39 PST 2019


zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 192321: Support css-color-4 rgb functions
https://bugs.webkit.org/show_bug.cgi?id=192321

Attachment 358098: Patch

https://bugs.webkit.org/attachment.cgi?id=358098&action=review




--- Comment #14 from zalan <zalan at apple.com> ---
Comment on attachment 358098
  --> https://bugs.webkit.org/attachment.cgi?id=358098
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358098&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:511
> +    auto consumeSeparator = [&] () -> bool {

wouldn't "auto consumeSeparator = [&] {" just work?

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:533
> +    auto consumeAlphaSeparator = [&] () {

() can be dropped.


More information about the webkit-reviews mailing list