[webkit-reviews] review granted: [Bug 195128] [ContentChangeObserver] Move WKSetObservedContentChange logic to ContentChangeObserver class. : [Attachment 363156] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 27 16:58:39 PST 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195128: [ContentChangeObserver] Move WKSetObservedContentChange logic to
ContentChangeObserver class.
https://bugs.webkit.org/show_bug.cgi?id=195128

Attachment 363156: Patch

https://bugs.webkit.org/attachment.cgi?id=363156&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 363156
  --> https://bugs.webkit.org/attachment.cgi?id=363156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363156&action=review

Want to do the .mm -> .cpp in this patch?

> Source/WebCore/page/ios/ContentChangeObserver.mm:225
> +    // We've already have a definite answer.

We've have? We have or We've had or We've received


More information about the webkit-reviews mailing list