[webkit-reviews] review granted: [Bug 195127] The parser is failing to record the token location of new in new.target. : [Attachment 363152] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 195127: The parser is failing to record the token location of new in
new.target.
https://bugs.webkit.org/show_bug.cgi?id=195127

Attachment 363152: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=363152&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 363152
  --> https://bugs.webkit.org/attachment.cgi?id=363152
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=363152&action=review

r=me with suggestion.

> Source/JavaScriptCore/parser/Parser.cpp:4678
> +    JSTokenLocation lastNewTokenlocation;

"l" in "location" seems lower case.

> Source/JavaScriptCore/parser/Parser.cpp:4682
> +	       lastNewTokenlocation = currentLocation;

Why not making this `lastNewTokenLocation = tokenLocation()` and remove
`currentLocation`?