[webkit-reviews] review granted: [Bug 194966] Web Inspector: Dark Mode: Network Overview Graph segments have distracting white box shadow : [Attachment 362811] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194966: Web Inspector: Dark Mode: Network Overview Graph segments have
distracting white box shadow
https://bugs.webkit.org/show_bug.cgi?id=194966

Attachment 362811: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=362811&action=review




--- Comment #13 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362811
  --> https://bugs.webkit.org/attachment.cgi?id=362811
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=362811&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTimelineOverviewGraph.css:40
> +    box-shadow: var(--timeline-odd-background-color) 1px 0 0;

Rather than repeat the `box-shadow` declaration, you could have another
variable that just defines the color, and just change that variable when
`:nth-child(even)`.

    box-shadow: var(--active-segment-box-shadow-color) 1px 0 0;

    --active-segment-box-shadow-color: var(--timeline-odd-background-color);
    --active-segment-box-shadow-color: var(--timeline-even-background-color);

> Source/WebInspectorUI/UserInterface/Views/Variables.css:285
> +	   --timeline-even-background-color: hsl(0, 0%, 25%);

I think we should add a comment here explaining that if
`--background-color-content` gets changed, this should also be adjusted to
match.