[webkit-reviews] review granted: [Bug 194967] Web Inspector: Styles: Command-/ should toggle edited property : [Attachment 362839] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 25 13:52:45 PST 2019
Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 194967: Web Inspector: Styles: Command-/ should toggle edited property
https://bugs.webkit.org/show_bug.cgi?id=194967
Attachment 362839: Patch
https://bugs.webkit.org/attachment.cgi?id=362839&action=review
--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 362839
--> https://bugs.webkit.org/attachment.cgi?id=362839
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=362839&action=review
r=me
Probably unrelated, but when I select multiple properties and press ⌘/, I hit
an assertion failure.
Models/CSSProperty.js:146:23: CONSOLE ERROR CSS property is already
disabled
We should probably just remove that assertion.
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:164
> + this._toggle();
NIT: we should assert (or even just set it) that the checkbox's state matches
the property's `enabled`.
console.assert(this._checkboxElement.checked === this.property.enabled);
> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:423
> + const index = parseInt(this._element.dataset.propertyIndex);
Style: this should be `let`.
More information about the webkit-reviews
mailing list