[webkit-reviews] review granted: [Bug 194819] Fix crash when opening Web Inspector after a WebSocket was blocked by content extensions : [Attachment 362415] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Loïc Yhuel
<loic.yhuel at softathome.com>'s request for review:
Bug 194819: Fix crash when opening Web Inspector after a WebSocket was blocked
by content extensions
https://bugs.webkit.org/show_bug.cgi?id=194819

Attachment 362415: Patch

https://bugs.webkit.org/attachment.cgi?id=362415&action=review




--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 362415
  --> https://bugs.webkit.org/attachment.cgi?id=362415
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362415&action=review

r=me, thanks for finding, fixing, and including a test!!

Let me know if you need me to set the commit-queue flag.

>
LayoutTests/http/tests/inspector/network/contentextensions/blocked-websocket-cr
ash.html:20
> +	   test(resolve, reject) {
> +	       // The inspector won't receive anything, so there is nothing to
expect.
> +	       // The test just makes sure the inspector initialization is done
> +	    resolve();
> +	}

Indentation got a little messed up here. But perhaps we should do something to
just verify that things worked. How about:

    suite.addTestCase({
	name: "Network.BlockedRequests.WebSocket",
	description: "Ensure Web Inspector works even with a blocked WebSocket
connection",
	test(resolve, reject) {
	    InspectorTest.pass("Web Inspector initialized.");
	    resolve();
	}
    });