[webkit-reviews] review granted: [Bug 194804] [LFC][Floats] Remove redundant intersecting logic : [Attachment 362363] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 19 13:00:26 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 194804: [LFC][Floats] Remove redundant intersecting logic
https://bugs.webkit.org/show_bug.cgi?id=194804

Attachment 362363: Patch

https://bugs.webkit.org/attachment.cgi?id=362363&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 362363
  --> https://bugs.webkit.org/attachment.cgi?id=362363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362363&action=review

> Source/WebCore/layout/floats/FloatingContext.cpp:325
> +	   return floating ?
floating->rectWithMargin().intersects(floatAvoiderRect) : false;

return floating && floating->rectWithMargin().intersects(floatAvoiderRect);


More information about the webkit-reviews mailing list