[webkit-reviews] review granted: [Bug 194776] [iOS] Dispatch additional events along with pointerdown and pointerup : [Attachment 362297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 18 09:37:41 PST 2019


Brent Fulgham <bfulgham at webkit.org> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 194776: [iOS] Dispatch additional events along with pointerdown and
pointerup
https://bugs.webkit.org/show_bug.cgi?id=194776

Attachment 362297: Patch

https://bugs.webkit.org/attachment.cgi?id=362297&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 362297
  --> https://bugs.webkit.org/attachment.cgi?id=362297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362297&action=review

Seems reasonable. r=me

> Source/WebCore/page/PointerCaptureController.cpp:136
>  

I guess this needs to be protected by "#if ENABLE(TOUCH_EVENTS) &&
PLATFORM(IOS_FAMILY)"

> Source/WebCore/page/PointerCaptureController.cpp:-173
> -	   

Whitespace.


More information about the webkit-reviews mailing list