[webkit-reviews] review granted: [Bug 194772] [ARM] Fix crash with sampling profiler : [Attachment 362276] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 18 09:50:51 PST 2019
Mark Lam <mark.lam at apple.com> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 194772: [ARM] Fix crash with sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=194772
Attachment 362276: Patch
https://bugs.webkit.org/attachment.cgi?id=362276&action=review
--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362276
--> https://bugs.webkit.org/attachment.cgi?id=362276
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=362276&action=review
r=me with fix.
> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:181
> + if (dest == ARMRegisters::sp) {
This is incorrect. You only need this alternative codegen if (dest ==
ARMRegisters::sp && src != dest). If (dest == ARMRegisters::sp && src ==
dest), the implementation below would generate more optimal code. For details,
see add(RegisterID rd, RegisterID rn, ARMThumbImmediate imm) in
ARMv7Assembler.h.
More information about the webkit-reviews
mailing list