[webkit-reviews] review granted: [Bug 194768] Add version number to cached bytecode : [Attachment 362264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 17 23:50:50 PST 2019


Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 194768: Add version number to cached bytecode
https://bugs.webkit.org/show_bug.cgi?id=194768

Attachment 362264: Patch

https://bugs.webkit.org/attachment.cgi?id=362264&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362264
  --> https://bugs.webkit.org/attachment.cgi?id=362264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362264&action=review

> Source/JavaScriptCore/runtime/CodeCache.h:152
> +	   close(fd);

Nit: I’d just create an onScopeExit after the branch to make sure it’s a valid
fd. I’d also remove the other close(fd)


More information about the webkit-reviews mailing list