[webkit-reviews] review granted: [Bug 194252] B3ReduceStrength: missing peephole optimizations for binary operations : [Attachment 361312] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 17 23:42:23 PST 2019

Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 194252: B3ReduceStrength: missing peephole optimizations for binary

Attachment 361312: Patch


--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 361312
  --> https://bugs.webkit.org/attachment.cgi?id=361312

View in context: https://bugs.webkit.org/attachment.cgi?id=361312&action=review


> Source/JavaScriptCore/ChangeLog:47
> +	   I did not list every single reordering of the arguments as the test
part of this patch is already significantly longer than the useful code, and
this combination should sample all the relevant paths.

That’s not our criteria for adding tests. Why don’t you just make it so your
test doesn’t hard code lhs/rhs to generate all combinations?

> Source/JavaScriptCore/b3/B3ReduceStrength.cpp:1002
> +			   &&

maybe use numeric_limits here?

> Source/JavaScriptCore/b3/B3ReduceStrength.cpp:2242
> +    // Turn any of these:

You should say for op Or/Xor

More information about the webkit-reviews mailing list