[webkit-reviews] review granted: [Bug 194320] Turn On Smart Delete : [Attachment 362183] Patch

Sat Feb 16 00:30:33 PST 2019

Ryosuke Niwa <rniwa at webkit.org> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 194320: Turn On Smart Delete
https://bugs.webkit.org/show_bug.cgi?id=194320

Attachment 362183: Patch

https://bugs.webkit.org/attachment.cgi?id=362183&action=review

--- Comment #73 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 362183
  --> https://bugs.webkit.org/attachment.cgi?id=362183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362183&action=review

> LayoutTests/editing/deleting/smart-delete-003.html:1
> +<html> 

Missing DOCTYPE.

> LayoutTests/editing/deleting/smart-delete-004.html:1
> +<html> 

Missing DOCTYPE.

> LayoutTests/resources/ui-helper.js:137
> +	   var rects = window.getSelection().getRangeAt(0).getClientRects();

Use const?