[webkit-reviews] review granted: [Bug 194733] [JSC] Shrink UnlinkedFunctionExecutable : [Attachment 362202] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194733: [JSC] Shrink UnlinkedFunctionExecutable
https://bugs.webkit.org/show_bug.cgi?id=194733

Attachment 362202: Patch

https://bugs.webkit.org/attachment.cgi?id=362202&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 362202
  --> https://bugs.webkit.org/attachment.cgi?id=362202
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362202&action=review

r=me

> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:45
> +static_assert(sizeof(UnlinkedFunctionExecutable) <= 128,
"UnlinkedFunctionExecutable should fit in a 128-byte cell to keep allocated
block only one just after initializing JSGlobalObject.");

I would rephrase the message as "UnlinkedFunctionExecutable should fit in a
128-byte cell to keep allocated blocks count to only one after initializing
JSGlobalObject."