[webkit-reviews] review granted: [Bug 194487] Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases) : [Attachment 361889] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 194487: Replace more uses of String::format with StringConcatenate (mostly
non-Apple platform-specific cases)
https://bugs.webkit.org/show_bug.cgi?id=194487

Attachment 361889: Patch

https://bugs.webkit.org/attachment.cgi?id=361889&action=review




--- Comment #8 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 361889
  --> https://bugs.webkit.org/attachment.cgi?id=361889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361889&action=review

> Tools/TestWebKitAPI/win/PlatformUtilitiesWin.cpp:54
> -    String filename =
String::format("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\%s.%s",
resource, extension);
> +    String filename =
makeString("..\\..\\..\\Tools\\TestWebKitAPI\\Tests\\WebKit\\", resource, '.',
extension);

My eyes! Raw strings will save us. No change necessary.

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:618
> +	   if (parentName && parentName[0]) {

Nice!

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:631
> +    builder.appendNumber(element->x(), 6, KeepTrailingZeros);

No chance necessary. Not so nice in my eyes :/